D007 define unit test for v4.0.0 compatibility layer#438
D007 define unit test for v4.0.0 compatibility layer#438syntron wants to merge 6 commits intoOpenModelica:masterfrom
Conversation
syntron
force-pushed
the
D007-test_v400
branch
from
9510c6d to
daa34cc
Compare
[ModelicaSystemABC] reorder code in __init__() [ModelicaSystem*] linter fixes
[OMTypedParser] compatibility layer [__init__/OMCSession] prepare compatibility layer [ModelicaSystem] define as compatibility layer [ModelicaSystemCmd] define as compatibility layer
add workflow to run unittests in ./tests tests from v4.0.0 fix test_linearization from v4.0.0 flake8 error: test_linearization.py:71:5: E741 ambiguous variable name 'l' this was fixed in: 'update usage of flake8 (OpenModelica#357)' (SHA1: 70cb446) fix test_ModelicaSystem - needed adaptions: * convert OMCPath to pathlib.Path * use correct exceptions define test workflows for v400
adeas31
left a comment
adeas31
left a comment
There was a problem hiding this comment.
I don't understand why we need new workflows to test v4.0.0?
What is the purpose of Test_v400.yml, Test_v400_py310.yml and Test_v4xx.yml?
We can test bu just adding an extra step,
- name: Run pytest
uses: pavelzw/pytest-action@v2
with:
verbose: true
emoji: true
job-summary: true
custom-arguments: '-v ./tests'
click-to-expand: true
report-title: 'Test Report'
- name: Run pytest for v4.0.0
uses: pavelzw/pytest-action@v2
with:
verbose: true
emoji: true
job-summary: true
custom-arguments: '-v ./tests_v400'
click-to-expand: true
report-title: 'Test Report'
Quite right; I tested it for myself using the different workflows to activate them as needed with corresponding settings. Would you prefere an update according to this proposal? |
|
updated PR - however, this will increase the time to run the unittests (factor 2?) |
Yes please. We might remove v4.0.0 tests in future. |
|
It fails here but should work on top of latest master (see also test in my fork: https://github.com/syntron/OMPython/actions/runs/25456426602) - updated with the fix included |
2 participants
this adds a second unittest branch (test_v400) to check for v4.0.0 compatibility
should be merged after D008! (PR #437)